common.cpp: add --enable-special-out and --disable-special-out for ov…#3
Closed
mofosyne wants to merge 1 commit intojart:grammar-tokenfrom
Closed
common.cpp: add --enable-special-out and --disable-special-out for ov…#3mofosyne wants to merge 1 commit intojart:grammar-tokenfrom
mofosyne wants to merge 1 commit intojart:grammar-tokenfrom
Conversation
…erride default special token handling behavior
Owner
|
The I don't think it makes sense here to have two flags. I did that before, with |
a285e3c to
d8b373c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…erride default special token handling behavior
Possible approach to address @HanClinto idea for a flag ggml-org#6923
Investigated using --conversation flag, but it touching multiple other logic so has much different semantic than this idea.
Also @jart would prefer keeping the different default special token behavior.
It would be nice if the 'settings' store has default behaviour + override flag... e.g. DEFAULT, OVERRIDE_TRUE, OVERRIDE_FALSE or something. But anyway this is the best approximation