mono - upgrading vitest, faker, biome, and types#1614
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 2485 2485
Branches 556 554 -2
=========================================
Hits 2485 2485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates several development dependencies, including Vitest, Biome, and various esbuild packages, along with their corresponding entries in the pnpm lockfile. I have reviewed the changes and suggest pinning the versions of Vitest and its related plugins, as well as explicitly adding Vite to the devDependencies to ensure stable and consistent dependency resolution.
| "@vitest/coverage-v8": "^4.1.3", | ||
| "@vitest/spy": "^4.1.3", |
There was a problem hiding this comment.
Vitest and its associated plugins (like @vitest/coverage-v8 and @vitest/spy) are tightly coupled and often require exact version matches for their peer dependencies to function correctly. Using caret ranges (^4.1.3) can lead to peer dependency conflicts if one package is updated independently of the others. It is recommended to use exact versions for these dependencies to ensure stability across the monorepo.
| "@vitest/coverage-v8": "^4.1.3", | |
| "@vitest/spy": "^4.1.3", | |
| "@vitest/coverage-v8": "4.1.3", | |
| "@vitest/spy": "4.1.3", |
| "@vitest/spy": "^4.1.3", | ||
| "rimraf": "^6.1.3", | ||
| "vitest": "^4.0.18", | ||
| "vitest": "^4.1.3", |
There was a problem hiding this comment.
vitest@4.1.3 specifies vite as a peer dependency (^6.0.0 || ^7.0.0 || ^8.0.0). While it is currently being resolved transitively in the lockfile (to 7.3.1), it is best practice to explicitly list vite in your devDependencies to ensure consistent resolution and to have direct control over its version. Additionally, using an exact version for vitest is recommended to match its plugins.
| "vitest": "^4.1.3", | |
| "vite": "7.3.1", | |
| "vitest": "4.1.3", |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mono - upgrading vitest, faker, biome, and types