Skip to content

mono - upgrading vitest, faker, biome, and types#1614

Merged
jaredwray merged 1 commit intomainfrom
mono---upgrading-vitest,-faker,-biome,-and-types
Apr 9, 2026
Merged

mono - upgrading vitest, faker, biome, and types#1614
jaredwray merged 1 commit intomainfrom
mono---upgrading-vitest,-faker,-biome,-and-types

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Apr 9, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mono - upgrading vitest, faker, biome, and types

@jaredwray jaredwray merged commit d352ff0 into main Apr 9, 2026
8 checks passed
@jaredwray jaredwray deleted the mono---upgrading-vitest,-faker,-biome,-and-types branch April 9, 2026 22:41
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d55398f) to head (fbac923).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1614   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2485      2485           
  Branches       556       554    -2     
=========================================
  Hits          2485      2485           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several development dependencies, including Vitest, Biome, and various esbuild packages, along with their corresponding entries in the pnpm lockfile. I have reviewed the changes and suggest pinning the versions of Vitest and its related plugins, as well as explicitly adding Vite to the devDependencies to ensure stable and consistent dependency resolution.

Comment on lines +25 to +26
"@vitest/coverage-v8": "^4.1.3",
"@vitest/spy": "^4.1.3",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Vitest and its associated plugins (like @vitest/coverage-v8 and @vitest/spy) are tightly coupled and often require exact version matches for their peer dependencies to function correctly. Using caret ranges (^4.1.3) can lead to peer dependency conflicts if one package is updated independently of the others. It is recommended to use exact versions for these dependencies to ensure stability across the monorepo.

Suggested change
"@vitest/coverage-v8": "^4.1.3",
"@vitest/spy": "^4.1.3",
"@vitest/coverage-v8": "4.1.3",
"@vitest/spy": "4.1.3",

"@vitest/spy": "^4.1.3",
"rimraf": "^6.1.3",
"vitest": "^4.0.18",
"vitest": "^4.1.3",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

vitest@4.1.3 specifies vite as a peer dependency (^6.0.0 || ^7.0.0 || ^8.0.0). While it is currently being resolved transitively in the lockfile (to 7.3.1), it is best practice to explicitly list vite in your devDependencies to ensure consistent resolution and to have direct control over its version. Additionally, using an exact version for vitest is recommended to match its plugins.

Suggested change
"vitest": "^4.1.3",
"vite": "7.3.1",
"vitest": "4.1.3",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant