-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix OTel Collector v0.141.0 API breaking changes for ToServer/ToClientConn and Kafka receiver/exporter #7694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: yurishkuro <[email protected]>
Co-authored-by: yurishkuro <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7694 +/- ##
==========================================
- Coverage 96.56% 96.53% -0.03%
==========================================
Files 384 384
Lines 19502 19511 +9
==========================================
+ Hits 18832 18835 +3
- Misses 486 490 +4
- Partials 184 186 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: yurishkuro <[email protected]>
Fixed in commit fb651ef. The issue was a nil pointer dereference when calling |
|
@copilot Kafka integration tests failed with the errors below. An upgrade of Kafka receiver seems to have breaking changes to the config 2025/12/05 04:12:39 application version: git-commit=, git-version=, build-date= 'receivers' error reading configuration for "kafka": decoding failed due to the following error(s): '' decoding failed due to the following error(s): '' has invalid keys: encoding, topic 'receivers' error reading configuration for "kafka": decoding failed due to the following error(s): '' decoding failed due to the following error(s): '' has invalid keys: encoding, topic |
Co-authored-by: yurishkuro <[email protected]>
Fixed in commit b524ffb. The Kafka receiver v0.141.0 removed the deprecated top-level |
🛑 Breaking Change
This upgrade of dependencies from OTel Collector introduces a breaking change in the Kafka exporter and receiver configuration: the
topicandencodingfields moved undertraceselement (open-telemetry/opentelemetry-collector-contrib#44568).Before:
After:
Fix for OTel Collector Upgrade PR #7694 ✅
topicandencodinginto signal-specifictracessectionconfig-kafka-ingester.yamlandconfig-kafka-collector.yamlSummary
Fixed build failures caused by breaking changes in OTel Collector v0.141.0:
1. ToServer/ToClientConn API Changes
Added nil pointer checks before calling
Host.GetExtensions()in:cmd/remote-storage/app/server.go(added import and nil check)cmd/query/app/server.go(2 locations with nil checks)2. Kafka Receiver/Exporter Configuration Changes
The Kafka receiver v0.141.0 removed deprecated top-level
topicandencodingfields. Updated configuration files:cmd/jaeger/config-kafka-ingester.yaml- Moved topic/encoding undertracessectioncmd/jaeger/config-kafka-collector.yaml- Moved topic/encoding undertracessectionAll tests now pass including the previously failing
TestNewServer_TLSConfigErrorand Kafka integration tests. ✅Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.