Skip to content
This repository was archived by the owner on Jul 22, 2019. It is now read-only.

Feature: Thresholds#1109

Open
meekzyr wants to merge 5 commits into
jabbink:developfrom
meekzyr:feature/thresholds
Open

Feature: Thresholds#1109
meekzyr wants to merge 5 commits into
jabbink:developfrom
meekzyr:feature/thresholds

Conversation

@meekzyr

@meekzyr meekzyr commented Aug 16, 2016

Copy link
Copy Markdown
Contributor

This pull request adds thresholds for a maximum amount of looted Pokestops and caught Pokemon. This will prevent the bot from continuously catching Pokemon and looting Pokestops, which normally leads to your account being flagged.

Changes made:

  • Added a threshold for caught Pokemon and looted Pokestops
  • Delay the tasks for 12 hours before resetting the threshold.

@meekzyr

meekzyr commented Aug 16, 2016

Copy link
Copy Markdown
Contributor Author

Ready for peer review.

@alexlautenschlager

Copy link
Copy Markdown
Contributor

Hmm it is somehow similar to my changes
#1095
However my changes simply stop the bot completely (instead stopping the single task)
Probably yours is better thought through

@alexlautenschlager

Copy link
Copy Markdown
Contributor

I believe yours is better, in any case i think 1000 is too much for Pokémon as i heard thats the value in ca 24h you get Banned for. Ah and do you know how i can "rewind" the last commits from my pull request here in github?

@alexlautenschlager

Copy link
Copy Markdown
Contributor

Ah and one more thing, could you also make the waittime which is 12h choosable from settings please?

@meekzyr

meekzyr commented Aug 16, 2016

Copy link
Copy Markdown
Contributor Author

@AlexBoulyga My apologies, I haven't checked pull requests recently. I had thought of how it would be beneficial to continue to walk around and hatch eggs, but maybe stopping entirely would be more human-like which could lead to less flagging.

@meekzyr

meekzyr commented Aug 16, 2016

Copy link
Copy Markdown
Contributor Author

@AlexBoulyga I don't know how to rewind commits, unfortunately. However, I will go ahead and change the values and add a setting for the delay time in the morning.

waitTimeMin = getPropertyIfSet("Minimal time to wait", "wait_time_min", defaults.waitTimeMin, String::toInt),

waitTimeMax = getPropertyIfSet("Maximal time to wait", "wait_time_max", defaults.waitTimeMax, String::toInt)
waitTimeMax = getPropertyIfSet("Maximal time to wait", "wait_time_max", defaults.waitTimeMax, String::toInt),

@jabbink jabbink Aug 16, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Maximum

EDIT: Oh lol I see you didn't add this.

@alexlautenschlager alexlautenschlager Aug 16, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was me, ill change it in my commit :)
FIXED

@HoreaM

HoreaM commented Aug 16, 2016

Copy link
Copy Markdown

not sure here is the best place to do this, I'm new to GitHub, sorry for my noobishness

Would it complicate things a lot to change it so that it keeps the values for Pokemons caught so far and Pokestops visited so far somewhere locally, so even if let's say the bot crashes or is stopped, if restarted it will continue from the previous values.

@meekzyr

meekzyr commented Aug 17, 2016

Copy link
Copy Markdown
Contributor Author

@HoreaM I believe this has recently added in #1129

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants