feat: add server.type filter and sort to Installation, Site, Domain#76
Merged
Conversation
turegjorup
added a commit
that referenced
this pull request
May 18, 2026
API Specification - Non-breaking changesAPI Changelog 1.0.0 vs. 1.0.0No changes detected |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #76 +/- ##
==========================================
Coverage ? 41.63%
Complexity ? 866
==========================================
Files ? 125
Lines ? 2738
Branches ? 0
==========================================
Hits ? 1140
Misses ? 1598
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds a "Server type" dropdown filter (Prod / Stg / DevOps / GPU via ServerTypeType::CHOICES) and makes the Type column header clickable to sort on those three admin lists. ServerTypeFilter learned to handle dotted property names by joining the relation itself — EasyAdmin doesn't auto-join for filters on nested paths (EasyCorp/EasyAdminBundle#4120). The filter reuses the plain relation name as the join alias to match EA's own sort-side auto-join, so combining filter + sort on the same association produces a single JOIN in the generated SQL.
f5d09a4 to
c303c0d
Compare
Codecov flagged 0% patch coverage on the new dotted-path handling. Three KernelTest cases cover: * flat property → no JOIN, compares on root alias * nested property → auto-LEFT-JOINs the relation under the plain alias * nested property when the alias already exists → no duplicate JOIN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Server type (Prod / Stg / DevOps / GPU) filter and makes the Type column header sortable on
/admin/installation,/admin/site, and/admin/domain.Files Changed
Test Plan