Disambiguate cameras with same product/vendor ids (issue #59)#60
Merged
Conversation
Fix issue where `AVCaptureDevice.usbDevice()` would return a USBDevice pointing to the wrong camera if multiple cameras with the same product id and vendor id are attached to the computer. The new approach is to use an iterator to lookup the cameras with the given vendor and product ids, and then loop through the results and match against their property dictionaries against the avDevice.localizedName since that seems to be the only reliable way to disambiguate between different cameras with otherwise similar properties.
Contributor
Author
|
There may be a better approach to solve this issue, but this is one that I came up with that works in my situation. I am happy to hear other ideas about how to solve this. |
Owner
|
I was going to tell you about using a function, but seems like you already did that :) Looks good, I am not on my machine, but I try it once I get it |
Owner
|
Seems to be working fine, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue where
AVCaptureDevice.usbDevice()would return a USBDevicepointing to the wrong camera if multiple cameras with the same product
id and vendor id are attached to the computer.
The new approach is to use an iterator to lookup the cameras with the
given vendor and product ids, and then loop through the results and
match against their property dictionaries against the
avDevice.localizedName since that seems to be the only reliable way to
disambiguate between different cameras with otherwise similar
properties.