Clean up types to support 8.1 more natively #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d types. Breaking change
…re that there's a way to trace origin
Owner
Author
|
@eric-therond @nikic i went a bit overboard refactoring. Internals are mostly changed, but results are largely unchanged (primary changes to parser and a new cli runner). I think I will also refactor the Printer a bit, but likely will do a separate PR for that since that will require significant rewriting of tests. I also found a few significant bugs in the implementation that I fixed (you can see in some of the tests changes). I will look to merge this end of the week to give some time to review and play. |
nikic
reviewed
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large breaking change, interfaces have changed.
More likely needs to be done to get this fully updated.