-6 flag in myip command #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BE-2399 Support `-6` (ipv6) flag in `myip` command
It may be enough to just try and make a request to If I do |
UmanShahzad
reviewed
Oct 9, 2023
ipinfo/cmd_myip.go
Outdated
| --token <tok>, -t <tok> | ||
| use <tok> as API token. | ||
| --ipv6, -6 | ||
| use IPv6 address. |
Contributor
There was a problem hiding this comment.
Suggested change
| use IPv6 address. | |
| get IPv6 address. |
ipinfo/cmd_myip.go
Outdated
| var fJSON bool | ||
| var fCSV bool | ||
| var fYAML bool | ||
| var fIPv6 bool |
Contributor
|
Will wait for Go SDK one, then @AhmadMujahid2k we need to update this repo to use the new version of that SDK. |
UmanShahzad
approved these changes
Oct 10, 2023
Contributor
UmanShahzad
left a comment
There was a problem hiding this comment.
Need to update go.mod and run go mod vendor otherwise this wont work
UmanShahzad
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.