Skip to content

Fixes #171 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UmanShahzad merged 1 commit into from
Sep 7, 2023
Merged

Fixes #171 #172

UmanShahzad merged 1 commit into from
Sep 7, 2023

Conversation

@Harisabdullah
Copy link
Contributor

@Harisabdullah Harisabdullah commented Sep 7, 2023 •
edited
Loading

Current output

mslm@mslm-ThinkPad-T480s:~/MHaris/cli$ ipinfo tool upper a::/126
0.10.0.0
mslm@mslm-ThinkPad-T480s:~/MHaris/cli$ ipinfo tool upper a::/127
0.10.0.0

Intended Output

mslm@mslm-ThinkPad-T480s:~/MHaris/cli$ ipinfo tool upper a::/126
a::3
mslm@mslm-ThinkPad-T480s:~/MHaris/cli$ ipinfo tool upper a::/127
a::1

Harisabdullah
Harisabdullah commented Sep 7, 2023
View reviewed changes
lib/cmd_tool_upper.go
if ipnet.IP.To4() != nil {
ipRange, _ := IPRangeStrFromCIDR(input)
upper = ipRange.End
} else if ipnet.IP.To16() != nil {
Copy link
Contributor Author

@Harisabdullah Harisabdullah Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPV6 CIDR were not handled separately.

Harisabdullah
Harisabdullah commented Sep 7, 2023
View reviewed changes
lib/cmd_tool_lower.go
func ActionForCIDR(input string) {
func ActionForCIDR(input string) error {
_, ipnet, err := net.ParseCIDR(input)
if err != nil {
Copy link
Contributor Author

@Harisabdullah Harisabdullah Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the output was correct for ipinfo tool lower but modified for the sake of consistency.

@UmanShahzad UmanShahzad merged commit aa426d1 into master Sep 7, 2023
@UmanShahzad UmanShahzad deleted the haris/fix-171 branch September 7, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@UmanShahzad UmanShahzad UmanShahzad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Harisabdullah @UmanShahzad