Tools to check IPv4 or IPv6 input #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@UmanShahzad Please check. |
UmanShahzad
reviewed
Aug 21, 2023
Contributor
UmanShahzad
left a comment
There was a problem hiding this comment.
Do fix issues commonly found in the other PRs that also appear here, then do ping me again @Kashaf-Sajid-Yaseen @awaismslm
Contributor
Author
|
@UmanShahzad Please check. |
UmanShahzad
reviewed
Aug 22, 2023
Contributor
UmanShahzad
left a comment
There was a problem hiding this comment.
Few things:
- Ensure we dont use underscores in the name of Golang functions. In the subcommand name itself it's fine but not in golang code.
- For printing, we should just print
<ip>,trueor<ip>,falsefor now instead of the full sentences of<ip> is na IPv4 input - Can we develop helper functions to check if the IP or IPNet (cidr) is v4/v6? Too many inlined conditionals are being used which makes it harder to read and reuse.
ipinfo/cmd_tool.go
Outdated
| case cmd == "is_v4": | ||
| err = cmdToolIs_v4() | ||
| case cmd == "is_v6": | ||
| err = cmdToolIs_v6() |
Contributor
There was a problem hiding this comment.
Func name should be cmdToolIsV6 (Similar for v4), even though the actual subcmd has an underscore.
ipinfo/cmd_tool_is_v6.go
Outdated
| Examples: | ||
| # Check CIDR. | ||
| $ %[1]s tool is_v6 1.1.1.0/30 |
Contributor
There was a problem hiding this comment.
Can we give a real v6 example
This was referenced Aug 23, 2023
Contributor
Author
|
@UmanShahzad Please check. |
UmanShahzad
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools to check the type of input (IPv4 & IPv6) entered by the user.