Skip to content

fix(IonicSlides): remove unnecessary autoplay option#26935

Merged
averyrousseau merged 1 commit into
mainfrom
FW-3512
Mar 8, 2023
Merged

fix(IonicSlides): remove unnecessary autoplay option#26935
averyrousseau merged 1 commit into
mainfrom
FW-3512

Conversation

@averyrousseau

@averyrousseau averyrousseau commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Repo/branch for testing: https://github.com/amandaejohnston/sandbox-ionic-angular/tree/swiper-migration-testing

When using the IonicSlides module with Swiper Element (https://swiperjs.com/element) and setting autoplay to true, a conflict occurs that leads to the slider flipping wildly between slides:

2023-03-08.13-56-26.mp4

Issue URL: N/A

What is the new behavior?

autoplay removed from the IonicSlides module to avoid the conflict. The default value in the Swiper API is false anyway, so the line wasn't doing anything.

Dev build: 6.6.2-dev.11678305229.18ce1c10

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added the package: core @ionic/core package label Mar 8, 2023
@averyrousseau averyrousseau marked this pull request as ready for review March 8, 2023 20:18
@averyrousseau averyrousseau requested a review from a team as a code owner March 8, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants