Merged
Conversation
jasonl99
reviewed
Jun 17, 2020
jasonl99
reviewed
Jun 17, 2020
jasonl99
reviewed
Jun 17, 2020
jasonl99
reviewed
Jun 17, 2020
Comment on lines
+61
to
+64
| data = data.sort_by { |row| row[date_time_key] } | ||
| output = [] | ||
| period_values = [] | ||
| previous_wma = nil |
Contributor
There was a problem hiding this comment.
Suggested change
| data = data.sort_by { |row| row[date_time_key] } | |
| output = [] | |
| period_values = [] | |
| previous_wma = nil | |
| data = data.sort_by { |row| row[date_time_key] } | |
| output = [] | |
| period_values = [] | |
| previous_wma = nil | |
Contributor
Author
There was a problem hiding this comment.
Changed as per request.
Contributor
Author
There was a problem hiding this comment.
I even added back the empty line after line 61 so as to be consistent with Ema.
jasonl99
reviewed
Jun 17, 2020
jasonl99
reviewed
Jun 17, 2020
jasonl99
requested changes
Jun 17, 2020
Contributor
jasonl99
left a comment
There was a problem hiding this comment.
There are some minor style (use blank lines to separate blocks of code (do..end, etc). I think scrambling the data order of the incoming data (in the rspec test) will also ensure that it's sorting properly when it comes in.
Otherwise, looks great!
alexnsolo
approved these changes
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.