Fix Regression in Model PSS and PSR, add check for zero-size initializers - #825
Merged
MayureshV1 merged 2 commits intoOct 9, 2025
Merged
Conversation
Signed-off-by: bfilipek <bartlomiej.filipek@intel.com>
javier-intel
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in model PSS and PSR by adding a safety check for zero-size initializers before calling SetExternalDataFields. Previously, the code assumed all initializers had non-zero size, but some models contain empty initializers that caused issues when converting RAW data to EXT data in memory.
- Added size validation check before calling
SetExternalDataFields - Added verbose logging for empty initializers that are skipped
- Prevents issues with zero-size initializers in OpenVino execution provider
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #817 we assumed that initializers's size is larger than zero. This is not the case for some models. While Initializers with RAW data usually works, as OV can skip them, there was an issue when we converted those initializers with RAW data to initializers with EXT data in memory.
So it's safe to add this check on the OVEP side (later we'll try to improve OpenVino side as well, and double check with their implementation)
Motivation and Context
CVS-174653