Skip to content

[OVEP] Fix for Dynamic backend creation for NPU. - #622

Merged
sfatimar merged 1 commit into
intel:ovep-developfrom
gupta-pallavi:pallavig/dynamic_backend_fix
Mar 27, 2025
Merged

[OVEP] Fix for Dynamic backend creation for NPU.#622
sfatimar merged 1 commit into
intel:ovep-developfrom
gupta-pallavi:pallavig/dynamic_backend_fix

Conversation

@gupta-pallavi

@gupta-pallavi gupta-pallavi commented Mar 18, 2025

Copy link
Copy Markdown

Description

[EISW-150896] Fix for Dynamic backend creation for NPU. Do not update tensor data for dynamic models.

Motivation and Context

https://jira.devtools.intel.com/browse/EISW-150896

@jatinwadhwa921
jatinwadhwa921 requested a review from ankitm3k March 19, 2025 03:21

@sfatimar sfatimar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are approved

@sfatimar

Copy link
Copy Markdown

LGTM. @ankitm3k @gupta-pallavi has made you a mandatory reviewer. Can you please review so we can merge it in.

@sfatimar

Copy link
Copy Markdown

@gupta-pallavi Branch is out of date please update.

@gupta-pallavi
gupta-pallavi force-pushed the pallavig/dynamic_backend_fix branch from 9552def to e5f8a18 Compare March 27, 2025 06:29
@ankitm3k
ankitm3k requested a review from preetha-intel March 27, 2025 06:39

@ankitm3k ankitm3k left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -425,8 +425,8 @@ void BasicBackend::StartAsyncInference(Ort::KernelContext& context, OVInferReque
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ORT_OVtensor is created and tensor is set in this else block in case of dynamic shaped model. The changes LGTM. But this condition has to be refactored as a follow up.

@sfatimar
sfatimar merged commit e240695 into intel:ovep-develop Mar 27, 2025
gupta-pallavi added a commit to gupta-pallavi/dynamic_backend that referenced this pull request Apr 2, 2025
sfatimar pushed a commit that referenced this pull request Apr 3, 2025
ankitm3k pushed a commit that referenced this pull request Apr 3, 2025
ankitm3k pushed a commit that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants