Epctx node base path fix and lint fix - #569
Merged
Merged
Conversation
Author
|
The internal ci seems to fail due to server connectivity issue , Jenkins internal ci pipeline passes |
|
LGTM |
sfatimar
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Use ep.context_file_path to get base path when creating session from memory * Fixed lint issues --------- Co-authored-by: Javier E. Martinez <javier.e.martinez@intel.com>
sfatimar
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Use ep.context_file_path to get base path when creating session from memory * Fixed lint issues --------- Co-authored-by: Javier E. Martinez <javier.e.martinez@intel.com>
ankitm3k
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Use ep.context_file_path to get base path when creating session from memory * Fixed lint issues --------- Co-authored-by: Javier E. Martinez <javier.e.martinez@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When creating EpContext nodes any external dependencies such as blobs are located relative to the model that contains the node. This PR fixes an issue where external dependencies were not found if session was created with a model passed from memory. In that case since the model name is empty the EP should use the session option ep.context_file_path to locate the base path.
Motivation and Context
Fix internal bug.
HAFP-2993