Add new error code to indicate the reset happended in the driver. #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
347520e to
e04fe6d
Compare
Contributor
Author
|
Hi, @XinfengZhang @Jexu, could you pls help to review this PR? |
XinfengZhang
requested changes
Jun 6, 2023
d7d0421 to
f18f2d5
Compare
Jexu
approved these changes
Jun 15, 2023
| * After the applications get VA_STATUS_HW_BUSY or VA_STATUS_SUCCESSFULL from vaSyncSurface(), | ||
| * it still can call vaQuerySurfaceError to find out further details to know if has real hw reset | ||
| * happened on this surface since umd and kmd could recover the context from reset with success in sometimes. | ||
| * VA_STATUS_HW_BUSY or VA_STATUS_SUCCESSFULL also could be passed in as "error_status". |
Contributor
There was a problem hiding this comment.
if there are one reset, and after re-run a while, there are another reset. how to know it?
each frame I need call it, first frame it is VADecodeReset, next frames it is invalid, then VADecodeReset again
Contributor
Author
There was a problem hiding this comment.
If user wants to know all the reset frames, then user needs to call vaQuerySurfaceError() for every frame and recode the reset information.
If user don't care about the reset, he can just call vaQuerySurfaceError() when get error from syncSurface().
Contributor
XinfengZhang
left a comment
There was a problem hiding this comment.
LGTM, even "success" is treated as "error code" , it looks a little tricky.
XinfengZhang
approved these changes
Jun 30, 2023
Use VADecodeReset to indeicate media reset/engine reset have happended in the driver, user can use vaQuerySurfaceError() to get the detail info to do some customized work. Signed-off-by: Pengxin, Yuan <pengxin.yuan@intel.com>
f18f2d5 to
dcf353c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use VA_STATUS_ERROR_RESET to indeicate media reset/engine reset have happended in the driver, user can use vaQuerySurfaceError() to get the detail info to do some customized work.