x11: use LIBVA_DRI3_DISABLE in GetNumCandidates #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XinfengZhang
approved these changes
Feb 16, 2023
1b43b18 to
bc0527e
Compare
Contributor
Author
|
Thanks team. Github was complaining the branch eing out of date, so I've rebased it. |
As reported by @zhmars, we need to check the override in both code paths. That's because we get only one candidate, while for Intel GPUs we have 2 drivers - so this might work when the user needs iHD, but will fail if they rely on the older driver. Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
bc0527e to
a884fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @zhmars, we need to check the override in both code paths.
That's because we get only one candidate, while for Intel GPUs we have 2 drivers - so this might work when the user needs iHD, but will fail if they rely on the older driver.