This repository was archived by the owner on Jan 7, 2023. It is now read-only.
Revert "egl/android: Update color_buffers querying for buffer age"#139
Merged
Conversation
sysopenci
reviewed
Dec 19, 2019
sysopenci
left a comment
There was a problem hiding this comment.
Autobuild started from pull-request-changes on this PR.
FAILURE: CheckBug Bad comments/Bugs
For more information, see: /absp/builders/celadon-autobuild/builds/1488
Contributor
|
How do you measure the FPS? Is it the one given by benchmark in UI or in the log output? |
Contributor
Author
|
@tpalli, it is given by benchmark in UI. You could install the Gfxbenchmark, and run the Manhattan in the first part. |
Contributor
IIRC there is also a figure given by log output, see if it matches? |
This reverts commit 87efbe4. We got one PnP regression with 87efbe4. When we run Gfxbenchmark, there will be 50% drop(from ~60 to ~30) for case Manhattan. Let's revert this for a hot fix, which won't block the code integration. We will continue to debug this issue with upstream mesa. Signed-off-by: Chenglei Ren <chenglei.ren@intel.com> Tracked-On: OAM-OAM-88862
feijiang1
approved these changes
Dec 20, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 87efbe4.
We got one PnP regression with 87efbe4. When we run Gfxbenchmark,
there will be 50% drop(from ~60 to ~30) for case Manhattan. Let's
revert this for a hot fix, which won't block the code integration.
We will continue to debug this issue with upstream mesa.
Signed-off-by: Chenglei Ren chenglei.ren@intel.com
Tracked-On: OAM-OAM-88862