Conversation
instruments/ondax/lm.py
Outdated
|
|
||
| # INNER CLASSES # | ||
|
|
||
| class AutomaticCurrentControl(object): |
There was a problem hiding this comment.
These classes should probably be prefixed with an underscore so that users don't think they should be accessing it via LM.AutomaticCurrentControl
|
A lot of these properties can be converted to using the property templates. For inner classes, you can also use the property templates if you define dummy def sendcmd(self, msg):
self._parent.sendcmd(msg)
def query(self, msg, size=-1):
return self._parent.query(msg, size)This will then allow you to put upper and lower bounds on all the properties with setters. |
|
Note that one of the things I changed was some of the units you were using in time-based properties. There was a lot of |
|
I'm going to assume my changes were okay. I might revisit some implementation details later, but I suppose we'll go with this for now. |
The Ondax Surelock Laser module has a communication protocol with few patterns, thus there is little to be gained other than confusion in using factory modules.