Skip to content

[Flutter Parent][MBL-13595] Add support for masquerading#665

Merged
JordanMarshall merged 6 commits intomasterfrom
parent/MBL-13595-masquerading
Apr 1, 2020
Merged

[Flutter Parent][MBL-13595] Add support for masquerading#665
JordanMarshall merged 6 commits intomasterfrom
parent/MBL-13595-masquerading

Conversation

@JordanMarshall
Copy link
Contributor

@JordanMarshall JordanMarshall commented Mar 29, 2020

No description provided.

@JordanMarshall JordanMarshall force-pushed the parent/MBL-13595-masquerading branch from 5aeac24 to f79e327 Compare March 30, 2020 14:02
@CalvinKern CalvinKern self-assigned this Mar 30, 2020
CalvinKern
CalvinKern suggested changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@CalvinKern CalvinKern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to allow masquerading as a non-observer as well? Currently I can act as a student (nothing crashes though).

@JordanMarshall
Copy link
Contributor Author

JordanMarshall commented Mar 31, 2020 •
edited
Loading

Do we want to allow masquerading as a non-observer as well? Currently I can act as a student (nothing crashes though).

Yes. If someone accidentally masquerades as a non-observer they probably don't want to be forced to log out and log in again to get the right user.

@CalvinKern
Copy link
Contributor

CalvinKern commented Mar 31, 2020

This is failing some tests for masquerade_screen_test on small devices, not sure if that's something we want to tackle now or if we'll focus on them after 3.2: https://app.bitrise.io/build/c6feff33af3c36ba#?tab=log <- landscape
https://app.bitrise.io/build/0a3394d88a5f4e82#?tab=log <- portrait

@CalvinKern
Copy link
Contributor

CalvinKern commented Mar 31, 2020

Functionality is great! Just those remaining cleanup items and we'll be golden!

@JordanMarshall
Copy link
Contributor Author

JordanMarshall commented Mar 31, 2020 •
edited
Loading

This is failing some tests for masquerade_screen_test

We'll worry about it post 3.2. I'll eat my shirt if admins or support are masquerading on a 3.2" phone.

Jordan Marshall added 2 commits March 31, 2020 14:24
CalvinKern
CalvinKern approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@CalvinKern CalvinKern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@JordanMarshall JordanMarshall merged commit c413251 into master Apr 1, 2020
@JordanMarshall JordanMarshall deleted the parent/MBL-13595-masquerading branch April 1, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CalvinKern CalvinKern CalvinKern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CalvinKern CalvinKern

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JordanMarshall @CalvinKern