This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Merged
Conversation
Also fixes a few bugs uncovered whilst doing that upgrade where e.preventDefault() wasn't called on events from Button elements.
This runs the jest tests in-band and with the inspector available
Really I just disabled most of them to be just warnings because it's not in scope to fix them
073b532 to
72c1fd3
Compare
Storybook is always with vulnerability
NSeydoux
approved these changes
Apr 12, 2022
Contributor
NSeydoux
left a comment
There was a problem hiding this comment.
I'm probably ot in the best position to assess the quality of the unit tests of React components, but this looks like a massive improvement over what was there previously.
| "no-shadow": "warn", | ||
| "react/require-default-props": "warn", | ||
| "react/default-props-match-prop-types": "warn", | ||
| noImplicitAny: "off", |
Contributor
Author
There was a problem hiding this comment.
Hey, there were just too many to change and it was mostly in the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades the Inrupt SDKs to the latest versions, migrates us to use
user-eventfrom react testing-library (the now recommended way for testing interactions in unit tests). Also upgraded isswrwhich was heavily out of date.Additionally we should now support react 18 without problems (hopefully), and audit issues should be resolved.