This repository was archived by the owner on May 25, 2021. It is now read-only.
Merged
Conversation
Contributor
Author
|
The PR for the TextEditor, as discussed! I just copied the src/ of the generated app to generators/app/templates/src/, will now double-check whether it actually works when you now generate this app. |
james-martin-jd
previously requested changes
Oct 21, 2019
generators/app/templates/src/containers/TextEditor/text-editor.component.js
Outdated
Show resolved
Hide resolved
generators/app/templates/src/containers/TextEditor/text-editor.component.js
Outdated
Show resolved
Hide resolved
generators/app/templates/src/containers/TextEditor/text-editor.component.js
Outdated
Show resolved
Hide resolved
generators/app/templates/src/containers/TextEditor/text-editor.component.js
Outdated
Show resolved
Hide resolved
generators/app/templates/src/containers/TextEditor/text-editor.component.js
Outdated
Show resolved
Hide resolved
generators/app/templates/src/containers/TextEditor/text-editor.style.js
Outdated
Show resolved
Hide resolved
generators/app/templates/src/containers/TextEditor/text-editor.style.js
Outdated
Show resolved
Hide resolved
Contributor
|
Another issue we discussed offline, we have typically shifted towards using functional components in our newer code instead of class components, now that hooks have leveled the playing field. You can see the newer /FormModel/ containers as an example. |
Done! Please re-review
james-martin-jd
suggested changes
Oct 31, 2019
generators/app/templates/src/containers/TextEditor/text-editor.component.js
Outdated
Show resolved
Hide resolved
generators/app/templates/src/containers/TextEditor/text-editor.component.js
Outdated
Show resolved
Hide resolved
generators/app/templates/src/containers/TextEditor/text-editor.component.js
Outdated
Show resolved
Hide resolved
generators/app/templates/src/containers/TextEditor/text-editor.component.js
Outdated
Show resolved
Hide resolved
generators/app/templates/src/containers/TextEditor/text-editor.component.js
Outdated
Show resolved
Hide resolved
james-martin-jd
approved these changes
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.