Fix a bunch of deprecation warnings#55
Merged
Merged
Conversation
alexfikl
commented
Feb 3, 2021
inducer
reviewed
Feb 3, 2021
e75167e to
4192e3d
Compare
* np.bool, np.int, np.float, np.complex and np.object are deprecated with numpy 1.20 * DOFArray.from_list is deprecated for a while too
Collaborator
Author
|
@inducer This seems to be getting some new and exciting failures which don't seem to have to do with my modifications. Any ideas? |
Collaborator
|
Probable cause - inducer/loopy@c78cd08 |
Collaborator
Author
Yep! inducer/loopy#217 seems to fix it locally. |
Owner
|
Thanks! Rerunning checks. |
inducer
approved these changes
Feb 4, 2021
Collaborator
Author
|
Hm, not quite sure what's happening on Edit: Ran it on gitlab and it seems to work fine there too. |
Owner
|
I have seen those "increasing GMRES residual" failures occasionally on the CI, but only on Github. I'm not sure what's going on. Let me rerun this again, to see if it's repeatable. |
Closed
alexfikl
commented
Feb 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(just got numpy 1.20 locally)
https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations