Tweak Array towards compatibility with arraycontext's Array protocol#606
Merged
Merged
Conversation
271a7e3 to
c9cc730
Compare
inducer
approved these changes
Jun 5, 2025
Owner
inducer
left a comment
There was a problem hiding this comment.
Thanks for puzzling this out! This looks great. I'll merge this now, the element-wise overloads can be done in a separate PR.
| return np.dtype(type(x)) | ||
|
|
||
|
|
||
| # FIXME: Overload these instead of returning union type? |
Owner
There was a problem hiding this comment.
Yes, I think that'd be an improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyright doesn't like
partialmethod, norArray.__getitem__having an argument name that doesn't match arraycontext'sArrayprotocol.