Skip to content

Correct DictOfNamedArrays.__eq__ #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 2 commits into from
Aug 14, 2021
Merged

Correct DictOfNamedArrays.__eq__ #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cab9b6
defines DictOfNamedArrays.__eq__
kaushikcfd Aug 14, 2021
5b9929a
test equality comparison of dict-of-named-arrays
kaushikcfd Aug 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pytato/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,13 @@ def __len__(self) -> int:
def __iter__(self) -> Iterator[str]:
return iter(self._data)

def __eq__(self, other: Any) -> bool:
if self is other:
return True

return (isinstance(other, DictOfNamedArrays)
and self._data == other._data)

# }}}


Expand Down
12 changes: 12 additions & 0 deletions test/test_pytato.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,18 @@ class BestArrayTag(Tag):
assert any(isinstance(tag, BestArrayTag) for tag in y.tags)


def test_dict_of_named_arrays_comparison():
# See https://github.com/inducer/pytato/pull/137
x = pt.make_placeholder("x", (10, 4), float)
dict1 = pt.make_dict_of_named_arrays({"out": 2 * x})
dict2 = pt.make_dict_of_named_arrays({"out": 2 * x})
dict3 = pt.make_dict_of_named_arrays({"not_out": 2 * x})
dict4 = pt.make_dict_of_named_arrays({"out": 3 * x})
assert dict1 == dict2
assert dict1 != dict3
assert dict1 != dict4


if __name__ == "__main__":
if len(sys.argv) > 1:
exec(sys.argv[1])
Expand Down