Skip to content

Use memoized variants for mapping expressions#603

Merged
inducer merged 6 commits into
mainfrom
memoized_mappers
May 6, 2022
Merged

Use memoized variants for mapping expressions#603
inducer merged 6 commits into
mainfrom
memoized_mappers

Conversation

@kaushikcfd

@kaushikcfd kaushikcfd commented Apr 25, 2022

Copy link
Copy Markdown
Collaborator

See inducer/pymbolic#90.

Draft because:

@kaushikcfd kaushikcfd force-pushed the memoized_mappers branch 4 times, most recently from 3561b6b to 1dffd33 Compare April 26, 2022 21:41
@kaushikcfd kaushikcfd force-pushed the memoized_mappers branch 6 times, most recently from 5aa13c2 to 65593ee Compare May 4, 2022 04:50
@inducer

inducer commented May 4, 2022

Copy link
Copy Markdown
Owner

Something like #611 (currently set to automerge if it passes) may address the failure in the Firedrake CI.

@kaushikcfd

Copy link
Copy Markdown
Collaborator Author

Something like #611 (currently set to automerge if it passes) may address the failure in the Firedrake CI.

Thanks, pulled from main. Already noticed an oddity: Pytential CI in the last attempt passed, but the CI times went up by 50%.

@inducer

inducer commented May 4, 2022

Copy link
Copy Markdown
Owner

Pytential CI in the last attempt passed, but the CI times went up by 50%.

Just this PR, or one of the other ones?

@inducer

inducer commented May 4, 2022

Copy link
Copy Markdown
Owner

@kaushikcfd

kaushikcfd commented May 4, 2022

Copy link
Copy Markdown
Collaborator Author

I think the variance between runs is pretty high, an older run: inducer/pymbolic#91 (a week ago) has 49 mins of potential CI time. So, not surprising quite surprising in that case. Looks mostly like a false alarm. (sorry)

@kaushikcfd kaushikcfd marked this pull request as ready for review May 5, 2022 16:42
@inducer inducer merged commit 3df44a6 into main May 6, 2022
@inducer inducer deleted the memoized_mappers branch May 6, 2022 16:44
@inducer

inducer commented May 6, 2022

Copy link
Copy Markdown
Owner

This looks good to me. Thanks for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants