Do not access LoopKernel.schedule#393
Merged
Merged
Conversation
- accessing LoopKernel.schedule warns about its deprecation
- sed commands:
git grep -l "l\.schedule\b" | xargs sed -i \
"s/l.scheduled/linearization/g"
cd test/
git grep -l "get_one_scheduled_kernel" | xargs sed -i \
"s/get_one_scheduled/get_one_linearized/g"
- formatting: flake8
Collaborator
Author
Owner
Lolsob. :) |
Owner
|
Thanks! |
Owner
|
For anyone reading this later, I reverted this via force-push because it caused lots of conflicts with #222. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git grep -l "l.schedule\b" | xargs sed -i
"s/l.scheduled/linearization/g"
cd test/
git grep -l "get_one_scheduled_kernel" | xargs sed -i
"s/get_one_scheduled/get_one_linearized/g"
Also updated LoopKernel.hash_fields