Skip to content

Make reduction accumulators not inherit predicates#235

Merged
inducer merged 5 commits into
masterfrom
reduction-accumulator-do-not-inherit-predicates
Feb 24, 2021
Merged

Make reduction accumulators not inherit predicates#235
inducer merged 5 commits into
masterfrom
reduction-accumulator-do-not-inherit-predicates

Conversation

@inducer

@inducer inducer commented Feb 23, 2021

Copy link
Copy Markdown
Owner

Closes #231. Closes inducer/pytential#57.

@inducer

inducer commented Feb 23, 2021

Copy link
Copy Markdown
Owner Author

The hope is that this will address inducer/pytential#57. The first round of CI passed (including the pytential downstream test). I'll rerun to gather more data.

@kaushikcfd kaushikcfd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the assignment instruction is surrounded by the predicate this should be fine. LGTM, thank you!

@inducer

inducer commented Feb 23, 2021

Copy link
Copy Markdown
Owner Author

@kaushikcfd Thanks for taking a look!

🎉 Passed a second time, too. I'll do another run and click auto-merge for that, so that if it passes, it goes in.

@inducer

inducer commented Feb 23, 2021

Copy link
Copy Markdown
Owner Author

Hmm, well, technically, these tests don't run test the Pytential example that was failing... so I created a dummy pytential PR: inducer/pytential#64

I guess I'd like to get a few runs of that in to see how it behaves. If it passes... maybe three...? of those, I'd call it good to go.

@inducer

inducer commented Feb 24, 2021

Copy link
Copy Markdown
Owner Author

inducer/pytential#64 passed three times. I'll call that good enough for me.

@inducer inducer enabled auto-merge February 24, 2021 00:26
@inducer inducer merged commit 1dc67d4 into master Feb 24, 2021
@inducer inducer deleted the reduction-accumulator-do-not-inherit-predicates branch February 24, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants