Fixing SSLHandshake issue while accessing api.indix.com#15
Merged
praveenselvam merged 7 commits intomasterfrom Oct 3, 2016
Merged
Fixing SSLHandshake issue while accessing api.indix.com#15praveenselvam merged 7 commits intomasterfrom
praveenselvam merged 7 commits intomasterfrom
Conversation
We trust the LetsEncrypt's root certificate as part of the http client's init
Apparently they are not supported on Android. Ref - http://stackoverflow.com/a/24869904
Member
Author
|
Please note still change still wouldn't work on Lolipop or any older version of Android yet. |
Member
Author
|
Just made some changes to make it work on Android as well. Verified it on Android level 22 - running the official Lollipop image. It needs some changes, which is also documented in the "Known issues" section of README. |
Contributor
|
@ashwanthkumar: Thanks for this. Will work on testing it out before closing. |
Contributor
|
@ashwanthkumar shouldn't we bump up the client version as well? |
Member
Author
|
@bbala-github Was not sure if we're going to make any changes on top of this - that's why didn't do a client version upgrade. May be I should have been working on a SNAPSHOT version - will fix that as part of the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @ind9/analytics @arijit-indix @praveenselvam