Skip to content

Add new slots and enums to Study; add new class Dataset#163

Merged
lopierra merged 17 commits into
mainfrom
issue-59
Mar 25, 2024
Merged

Add new slots and enums to Study; add new class Dataset#163
lopierra merged 17 commits into
mainfrom
issue-59

Conversation

@lopierra

Copy link
Copy Markdown
Member

closes #59

@lopierra lopierra requested a review from madanucd March 20, 2024 23:26
@lopierra lopierra self-assigned this Mar 20, 2024
Comment thread src/linkml/include_study.yaml
definition_uri: include:studyDesign
description: Overall design of study, including whether it is longitudinal and whether family members/unrelated controls are also enrolled
title: Study Design
range: string

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any use cases to query or filter for data based on studyDesign?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not currently, but it might be nice to be able to search for longitudinal studies, or family studies. This field (and the Selection Criteria field) will probably be used more heavily for clinical trials, so there might be more opportunities to standardize when we have more trials

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, from past modeling and ontology work on omics data I am more used to seeing study design as an enum to be able to filter and query data. Are the current thoughts that the range may change to an enum in the future and any past data re-annotated?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lopierra if this field does change to an enum in the future and previous data needs to be re-annotated, can we document this in the project plan?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think several fields should be changed to enums in the future. We're still determining where to document our plans, but at the very least it should be a github issue.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've listed the fields that need your help in #108

@lopierra

lopierra commented Mar 21, 2024 via email

Copy link
Copy Markdown
Member Author

prefix_reference: https://w3id.org/linkml/
mesh:
prefix_prefix: mesh
prefix_reference: http://id.nlm.nih.gov/mesh/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @madanucd!

@madanucd madanucd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@twhetzel twhetzel self-requested a review March 25, 2024 19:24

@twhetzel twhetzel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one open question, but otherwise looks good to me.

@lopierra lopierra merged commit 21659d9 into main Mar 25, 2024
@madanucd madanucd deleted the issue-59 branch July 16, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Study fields to data model

3 participants