Conversation
|
torstees
left a comment
There was a problem hiding this comment.
Let's create a new file, docs/term-expansion.md which explains what is happening:
- Link out to Term Weaver and summarize which LinkML features it supports (source_nodes and include_self = true/false, is_direct = true/false) Probably worth pointing out it does not support 'traverse_up'
- Explain the new just targets, _source_enums and _expand (what do they do, etc)
- point out any new dependencies you added: (_expand is now a dependency of gen-project, etc)
- Add this new file to the nav section in the mkdocs.yml
It is probably worth doing #1 and 4 above for the cam_source as well.
|
With regards to the output, using this example:
This is what I'd expect to see (very close!)
I believe this would validate and is consistent with what was in the manually defined items. Note that github is flattening these on display, there is a nested whitespace still! |
|
I also discussed with Eric checking the linting- it'd be good to either update the code / output to come back clean or understand how we need to adjust the linter in these models. |
I made a small commit containing a fix for the linter rules. This repo now returns a green arrow when running 'just lint'. @yelenacox If you could copy these changes/files over to cam-source-enums, that will ensure that we don't miss other things as they occur. |
|
@RobertJCarroll I have updated the output to the format specified in the comment. |
Thanks Eric- have you been able to find the "original" linting rules? I haven't and tried a few times in the last few weeks. I would like to understand the what's different here. The dash is the main element I'd be "concerned" about, though I don't think it'd be problematic. |
RobertJCarroll
left a comment
There was a problem hiding this comment.
This looks good to me. Glad everything is validating!
@RobertJCarroll There is this page. The default is uppersnake, and my change provides a lighter restriction (alphanumeric, "_", "-" and ":"). Are you concerned about allowing the dash or are you concerned that we will see them in the future? The latter should be currently permitted, but we can remove the "-" if that sounds risky to you. |
No description provided.