Skip to content

package: ensure all deb requires are present#237

Merged
dumbmoron merged 1 commit intomainfrom
fixdeb
Apr 5, 2026
Merged

package: ensure all deb requires are present#237
dumbmoron merged 1 commit intomainfrom
fixdeb

Conversation

@dumbmoron
Copy link
Copy Markdown
Member

No description provided.

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 31, 2026

Important Files Changed

Filename Overview
docker/package.Dockerfile Adds a RUN apt install step for Chromium runtime libraries needed by the ldd sanity check in mkdeb.sh. Uses --no-install-recommends to keep the image lean.
package/mkdeb.sh Adds a pre-build sanity check that extracts the helium binary from the tarball, runs ldd against it, and fails if any shared libraries are reported as not found. The EXIT trap is correctly updated to cover the new temp file, but ldd failures themselves are not explicitly caught.

Reviews (2): Last reviewed commit: "package: ensure all deb requires are pre..." | Re-trigger Greptile

Comment thread package/mkdeb.sh Outdated
Comment thread package/mkdeb.sh
@dumbmoron
Copy link
Copy Markdown
Member Author

@greptileai

@dumbmoron dumbmoron merged commit 3763834 into main Apr 5, 2026
5 checks passed
@dumbmoron dumbmoron deleted the fixdeb branch April 5, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants