expose SongVolume and PreviewVolume in Manifest Attributes#38
Open
Unleashed2k wants to merge 2 commits intoiminashi:mainfrom
Open
expose SongVolume and PreviewVolume in Manifest Attributes#38Unleashed2k wants to merge 2 commits intoiminashi:mainfrom
Unleashed2k wants to merge 2 commits intoiminashi:mainfrom
Conversation
iminashi
reviewed
Feb 22, 2026
|
|
||
| member val SongPartition: Nullable<int> = Nullable() with get, set | ||
|
|
||
| member val SongVolume: Nullable<float32> = Nullable() with get, set |
Owner
There was a problem hiding this comment.
I didn't include these since when importing official files, the volumes need to be read from the .bnk files anyway.
These should have comments:
// Only found in customs (created with the Toolkit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rocksmith manifests include SongVolume and PreviewVolume, but Attributes.fs currently omits them.
I'm working on a CFSM2 that needs to open PSARC files directly in DLC builder.
Currently, only .rs2dlc project files are handled from CLI, this small change adds support for .psarc, triggering the existing Import PSARC flow (same as File -> Import PSARC File)