fix(hough): make intersection_points() more general and stable - #742
Closed
bioinformatist wants to merge 1 commit into
Closed
fix(hough): make intersection_points() more general and stable#742bioinformatist wants to merge 1 commit into
intersection_points() more general and stable#742bioinformatist wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generality
Though the
angle_in_degreesofPolarLinerepresents for an angle, it'su32, and the Miri has no idea about the range. So the more general way is to usesin/cosfor special cases.Robustness
The trigonometric functions has unspecified precision at the moment, as well as the
mul_addis targeted to the dedicatedfmainstruction. That means, it's possible for the line has a calculated position which is slightly "outside" the box, while the true location is "inside".To solve it, a tolerance was added for judgement, then the final coordinates were restricted back to the border for accurate coordinates. This version works well with Miri.