fix integration tests#739
Merged
cospectrum merged 2 commits intoDec 16, 2025
Merged
Conversation
Contributor
|
I don’t like the solution based on build.rs |
Author
|
I know the point. Having two versions of ground truth is indeed redundant and confusing. I'm trying to implement the old Sincerely apologize for misunderstanding. |
bioinformatist
force-pushed
the
test/fix_integration_tests
branch
from
December 16, 2025 06:14
a84393b to
38ad23e
Compare
Author
|
Sorry for the delay. This time I manually implemented the conversion method as same as the one in I suppose this way is stable enough that we have no need to modify the ground truth in the future. Thanks for your tips! |
cospectrum
approved these changes
Dec 16, 2025
OrangeHoopla
pushed a commit
to OrangeHoopla/orange-imageproc
that referenced
this pull request
May 8, 2026
* fix: implement the same converting method for gray as `v0.25.0` * fix: fix type inferring problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current CI failure is mainly due to the color space casting change, like image-rs/image@603e97d. The change is positive, though not backward compatible.
I reckon the better way is to respect the new logic but keep the old conversions by conditional compilation to satisfy
direct-minimal. It was finally implemented by abuild.rsscript, which referred torust-openssl's approach.