Closed
Conversation
Author
|
cc @jclulow, please take a look. :) Aside, I have not yet figured out how to include these few headers in sysroot's Makefile: https://github.com/am11/arcade/blob/cc67bb38f3bcafe34c3d04b92cb04747b3d58a97/eng/common/cross/build-rootfs.sh#L313. If you could help getting those headers in the sysroot's next release, that would be great. Meanwhile, I am fetching them from illumos-gate repo for dotnet libraries build. |
Author
|
As per the discussion on IRC, due to the different version requirements in various downstreams, I have inlined this script in: dotnet/arcade#5584. When next release of sysroot will pick up the missing headers, I will cleanup the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this script present in the official repository, both rust and dotnet can source it from a single source of truth. e.g. https://github.com/am11/arcade/blob/cc67bb38f3bcafe34c3d04b92cb04747b3d58a97/eng/common/cross/build-rootfs.sh#L284
I have made some modifications (additional commits) on @jclulow's original script from his rust fork.
SYSROOT_DIR.ln -fs(instead ofln -s) avoids removing the existing links.xtrace.bash -x scripts/gcc-toolchain.sh.