Skip to content

Fix stack overflow exception in CSharpResolver #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
siegfriedpammer merged 2 commits into from
May 17, 2025
Merged

Fix stack overflow exception in CSharpResolver #3471

siegfriedpammer merged 2 commits into from
May 17, 2025

Conversation

@ds5678
Copy link
Contributor

@ds5678 ds5678 commented May 5, 2025

Resolves #3466

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.
  • Which part of this PR is most in need of attention/improvement?
  • At least one test covering the code changed

siegfriedpammer
siegfriedpammer reviewed May 6, 2025
View reviewed changes
@ds5678 ds5678 force-pushed the fix-stack-overflow-exception branch from 0392611 to 07f0921 Compare May 7, 2025 23:42
@ds5678
Copy link
Contributor Author

ds5678 commented May 8, 2025

Is there anything else that needs done?

@siegfriedpammer siegfriedpammer requested a review from dgrunwald May 9, 2025 17:59
@siegfriedpammer siegfriedpammer merged commit 0261ca3 into icsharpcode:master May 17, 2025
5 checks passed
@siegfriedpammer
Copy link
Member

siegfriedpammer commented May 17, 2025

sorry for the wait!

@ds5678
Copy link
Contributor Author

ds5678 commented May 17, 2025

Thanks for the merge!

@ds5678 ds5678 deleted the fix-stack-overflow-exception branch May 17, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedpammer siegfriedpammer siegfriedpammer left review comments

@dgrunwald dgrunwald Awaiting requested review from dgrunwald

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stack overflow involving explicit conversions

2 participants

@ds5678 @siegfriedpammer