Skip to content

Update query string decoding to decode pluses#22

Open
jvasseur wants to merge 1 commit intoicicleio:v0.3.xfrom
jvasseur:fix-pluses-decoding
Open

Update query string decoding to decode pluses#22
jvasseur wants to merge 1 commit intoicicleio:v0.3.xfrom
jvasseur:fix-pluses-decoding

Conversation

@jvasseur
Copy link
Copy Markdown
Contributor

@jvasseur jvasseur commented Sep 7, 2016

When decoding a query string pluses are not decoded.

This is a problem for 2 reasons:

  • It doesn't match the PHP behavior.
  • When using this value to create a new request the plus is encoded resulting in a different request.

Since the decode function is used to decode other parts of the URI I didn't update it and instead used urldecode directly when decoding query parts.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 7, 2016

Coverage Status

Coverage remained the same at 61.346% when pulling 065ad87 on jvasseur:fix-pluses-decoding into 69e66ac on icicleio:v0.3.x.

@sagebind
Copy link
Copy Markdown

sagebind commented Sep 9, 2016

Possibly related: #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants