Skip to content

Allowed building dev version of the API references from Github Actions#3173

Merged
mnocon merged 5 commits into
5.0from
php-api-ref-dev-version
May 20, 2026
Merged

Allowed building dev version of the API references from Github Actions#3173
mnocon merged 5 commits into
5.0from
php-api-ref-dev-version

Conversation

@mnocon
Copy link
Copy Markdown
Contributor

@mnocon mnocon commented May 5, 2026

The goal is to be able generate the PHP API reference from the dev version as soon as the code freeze is announced, so that we can merge this to the release notes PRs and add the missing links.

Contains TMP commit: 42e2b86 that must be removed before merging

Screenshot 2026-05-15 at 16 15 56

Two tests:

  1. Latest stable tag:

https://github.com/ibexa/documentation-developer/actions/runs/25371338588/job/74395337962

Result: Branch 'api_refs_v5.0.9' is not ahead of base '5.0' and will not be created

So the result is the same - the script was run with:

    BASE_BRANCH: 5.0
    DXP_VERSION: v5.0.9
    BASE_DXP_BRANCH: 
    VIRTUAL_DXP_VERSION: 
  1. Latest dev version:
    BASE_BRANCH: 5.0
    DXP_VERSION: v5.0.x-dev
    BASE_DXP_BRANCH: 5.0
    VIRTUAL_DXP_VERSION: 5.0.9

Build: https://github.com/ibexa/documentation-developer/actions/runs/25921140306/job/76190184119
Result: #3204

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Preview of modified files: no change to preview.

@mnocon mnocon force-pushed the php-api-ref-dev-version branch from 9d7d312 to 42e2b86 Compare May 15, 2026 12:53
@mnocon mnocon marked this pull request as ready for review May 15, 2026 14:09
@mnocon mnocon requested a review from a team May 15, 2026 14:16
@ibexa-workflow-automation-1 ibexa-workflow-automation-1 Bot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team May 15, 2026 14:16
@mnocon mnocon added the Wait with merge PRs that shouldn't be merged instantly label May 15, 2026
Copy link
Copy Markdown
Contributor

@adriendupuis adriendupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code.
I would have passed them as command line arguments or options but this can be difficult. And there is a good workaround to pass temporary env vars to a command.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would document this in tools/api_refs/README.md

I guess I can now run locally something like:

DXP_VERSION=v5.0.x-dev BASE_DXP_BRANCH=5.0 VIRTUAL_DXP_VERSION=5.0.10 tools/api_refs/api_refs.sh ~/my/path/to/auth.json

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 9329392 , thanks!

Comment thread .github/workflows/api_refs.yaml Outdated
@mnocon mnocon force-pushed the php-api-ref-dev-version branch from 54b2aa7 to 9329392 Compare May 19, 2026 19:13
Comment thread tools/api_refs/README.md Outdated
Comment thread tools/api_refs/README.md
@adriendupuis adriendupuis force-pushed the php-api-ref-dev-version branch from df91567 to 2339246 Compare May 20, 2026 13:32
@mnocon mnocon force-pushed the php-api-ref-dev-version branch from 2339246 to 03a37c6 Compare May 20, 2026 13:37
@sonarqubecloud
Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@mnocon mnocon merged commit f93c65b into 5.0 May 20, 2026
11 checks passed
@mnocon mnocon deleted the php-api-ref-dev-version branch May 20, 2026 13:45
mnocon added a commit that referenced this pull request May 20, 2026
#3173)

* Allowed building dev version of the API references from Github Actions

* Added GitHub token to the workflow

* Added Readme

* Update .github/workflows/api_refs.yaml

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>

* Apply suggestion from @adriendupuis

---------

Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs DOC review Wait with merge PRs that shouldn't be merged instantly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants