IBX-11083: Extending collaboration described in Developer Documentation#3055
Merged
Conversation
Preview of modified filesPreview of modified Markdown: |
ciastektk
requested changes
Feb 26, 2026
ciastektk
approved these changes
Feb 26, 2026
dabrt
requested changes
Mar 6, 2026
adriendupuis
requested changes
Mar 10, 2026
Contributor
adriendupuis
left a comment
There was a problem hiding this comment.
See #3078 for the addition of missing files and the fix of others.
7 tasks
* Add services.yaml and Mapper.php * Move SQL to files * Remove copyright for sharability * Rector * collaboration_search_reference: Fix highlights * collaboration/config/services.yaml: Fixes * collaboration/config/services.yaml: Format * Move template to storefront theme standard/cart/view.html.twig is always overridden by storefront/cart/view.html.twig from the bundle As the template depends on and extends the storefront theme, they're part of it. * Redesign share.html.twig for storefront * Simplify cart/view.html.twig * Redesign share_result.html.twig for storefront
adriendupuis
approved these changes
Mar 13, 2026
Contributor
There was a problem hiding this comment.
It just need an harmonization of the directory paths.
- I would always use the word "directory" and not the word "folder" which is more to be reserved for the content type.
- I would add the trailing slash to emphase on those paths being to directories.
- I would always start with root directory
src/.
dabrt
approved these changes
Mar 16, 2026
Contributor
dabrt
left a comment
There was a problem hiding this comment.
Please see my responses to comments, you may want to consider making some cosmetic changes.
|
code_samples/ change reportReport's diff is too long to be displayed in a comment. |
7 tasks
adriendupuis
added a commit
that referenced
this pull request
Mar 18, 2026
…on (#3055) * extending collaboration described in dev-doc * PHP & JS CS Fixes * Trigger CI * fixes * PHP & JS CS Fixes * card added * fixes after dev-rev * [PHPStan] Fixed reported errors * IBX-11083: Add missing code, fix code (#3078) * Add services.yaml and Mapper.php * Move SQL to files * Remove copyright for sharability * Rector * collaboration_search_reference: Fix highlights * collaboration/config/services.yaml: Fixes * collaboration/config/services.yaml: Format * Move template to storefront theme standard/cart/view.html.twig is always overridden by storefront/cart/view.html.twig from the bundle As the template depends on and extends the storefront theme, they're part of it. * Redesign share.html.twig for storefront * Simplify cart/view.html.twig * Redesign share_result.html.twig for storefront * screenshots added * screenshots added * fixes * small fixes --------- Co-authored-by: julitafalcondusza <julitafalcondusza@users.noreply.github.com> Co-authored-by: Tomasz Kryszan <tomasz.kryszan@ibexa.co> Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
7 tasks
| public function __construct( | ||
| private Repository $repository, | ||
| private CartServiceInterface $cartService, | ||
| private ProxyGeneratorInterface $proxyGenerator |
Contributor
There was a problem hiding this comment.
Dependency ignored in following #3093
Still, PhpStorm doesn't like the use of a class tagged as @internal
adriendupuis
added a commit
that referenced
this pull request
Mar 24, 2026
…on (4.6) (#3094) * IBX-11083: Extending collaboration described in Developer Documentation (#3055) * Downgrade to Commerce 4.6.28 / PHP 7.4 --------- Co-authored-by: julitafalcondusza <julitafalcondusza@users.noreply.github.com> Co-authored-by: Tomasz Kryszan <tomasz.kryszan@ibexa.co> Co-authored-by: adriendupuis <adriendupuis@users.noreply.github.com> Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extending collaboration described in Developer Documentation
Checklist