IBX-8452: Fixed string substitution for Plural Value Object when casting to string#360
Closed
alongosz wants to merge 4 commits into
Closed
IBX-8452: Fixed string substitution for Plural Value Object when casting to string#360alongosz wants to merge 4 commits into
alongosz wants to merge 4 commits into
Conversation
747304d to
ed870e1
Compare
|
Member
|
@alongosz Rebase is needed here |
`\Ibexa\Contracts\Core\Repository\Values\Translation\Plural` had an incorrect casting to string implementation which resulted in the effect opposite to the desired one
ed870e1 to
b356977
Compare
|
Member
Author
Member
|
@alongosz It make sense for me. |
Member
Author
|
Closing in favor of #394. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Pending 3.3 backport
Description:
When an instance of
Pluralvalue object was cast to string, it produced results opposite to the expected. For plural result it used singular message and for singular result - a plural one.TBD if my assumptions here are correct and if so this needs to be re-targeted to either 3.3 or 4.6
Fixed the issue via a042cf0. The other commits introduce more strictness.
For QA:
TBD if QA is needed / feasible.