fix(auth): restore interactive login menu in TTY for v1.3.13#25
fix(auth): restore interactive login menu in TTY for v1.3.13#25ramhaidar wants to merge 2 commits intoiam-brain:mainfrom
Conversation
- Use a bundled directory-based lock when proper-lockfile cannot be resolved so cache locking still works in packaged/runtime environments. - Target: core
- Remove the inputs guard from the interactive browser auth path so TTY users can reach the account-adding menu even when no prompt data is passed. - Target: auth
|
Thank you for testing @adevwithpurpose 👍 |
There was a problem hiding this comment.
Can you split the unrelated lockfile changes into a new PR?
There was a problem hiding this comment.
The auth fix looks right, but can you please add a regression test for the actual failing path: TTY browser auth when authorize() is called with no inputs argument? Current tests only cover authorize({}), which is likely why this regression still exists. Ideally, add one focused unit test in codex-native-oauth-auth-methods.test.ts and, if you want to be extra safe, one wiring-level test that calls browserMethod.authorize() with no args.
|
@iam-brain thanks for fixing these, sorry i just read it after you closed the PR |
Issue for this PR
Fixes #24
What does this PR do?
This fixes the v1.3.13 regression where the custom
opencode-codex-authmenu was not shown inopencode auth login.This PR also hardens lock handling by adding a fallback lock strategy when
proper-lockfileimport resolution is unavailable in some runtimes, preventing lock-related auth/cache failures.How did you verify your code works?
opencode auth login.