Disable xpath escape

[rhegner]

I had a second problem with my "Sunrise Internet Box".

Attempting to read the value of the following xpath failed:

Device/IP/Interfaces/Interface[Alias='IP_DATA']/IPv4Addresses/IPv4Address[Alias='IP_DATA_ADDRESS']/IPAddress

Instead of the IP address I was looking for, get_value_by_xpath returned a JSON structure with lots of status information in it, but not the IP address I was looking for. Turns out that url quoting messed things up.

So I added a new parameter to the get_value_by_xpath function:

The following now returns the desired IP address as expected:

await client.get_value_by_xpath("Device/IP/Interfaces/Interface[Alias='IP_DATA']/IPv4Addresses/IPv4Address[Alias='IP_DATA_ADDRESS']/IPAddress", { "capability-flags": { "interface": True }}, False)

[rhegner]

PS: Depending on what the original intent was for using that url quoting, a more elegant approach could be to specify the required characters as "safe characters" (instead of introducing a new parameter).

The following works fine for me too:

        actions = {
            "id": 0,
            "method": "getValue",
            "xpath": urllib.parse.quote(xpath, "/=[]'"),
            "options": options if options else {},
        }

https://docs.python.org/3/library/urllib.parse.html#urllib.parse.quote

[iMicknl]

@rhegner I would prefer your second option, to not add additional parameters here :)

[rhegner]

Yes, it's cleaner. I updated my PR.

[iMicknl]

Thanks, LGTM!

[rhegner]

@iMicknl do you plan to release a new version of your library with this PR included anytime soon?

[iMicknl]

@iMicknl do you plan to release a new version of your library with this PR included anytime soon?

Done!