Add possibility in example to ignore cert errors and fix the verify_ssl assignment in code#353
Merged
iMicknl merged 2 commits intoiMicknl:mainfrom Oct 15, 2024
bunnis:fix_permanent_ssl_check_true
Merged
Add possibility in example to ignore cert errors and fix the verify_ssl assignment in code#353iMicknl merged 2 commits intoiMicknl:mainfrom bunnis:fix_permanent_ssl_check_true
iMicknl merged 2 commits intoiMicknl:mainfrom
bunnis:fix_permanent_ssl_check_true
Conversation
…sl assignment in code
iMicknl
reviewed
Oct 7, 2024
iMicknl
requested changes
Oct 14, 2024
Owner
iMicknl
left a comment
There was a problem hiding this comment.
Can you run pre-commit on both your PRs? Both PRs are not passing CI/CD due to style issues.
Contributor
Author
|
Could you let me know how I do that? |
Owner
If you use the devcontainer, it should be there by default where you commit. Otherwise you can run |
iMicknl
approved these changes
Oct 15, 2024
Contributor
Author
|
Great thank you, sorry for that, I don't really know much about these tools |
jsongerber
pushed a commit
to jsongerber/python-sagemcom-api
that referenced
this pull request
Nov 8, 2024
…sl assignment in code (iMicknl#353) This addresses iMicknl#298, adding it explicitly to the example and making it easier for new users to toggle it. Additionally, the TCPConnector assignment was broken, and this was fixed too. --------- Co-authored-by: Mick <mick@imick.nl>
bakonyiferenc
pushed a commit
to bakonyiferenc/python-sagemcom-api
that referenced
this pull request
Dec 16, 2025
…sl assignment in code (iMicknl#353) This addresses iMicknl#298, adding it explicitly to the example and making it easier for new users to toggle it. Additionally, the TCPConnector assignment was broken, and this was fixed too. --------- Co-authored-by: Mick <mick@imick.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #298, adding it explicitly to the example and making it easier for new users to toggle it.
Additionally, the TCPConnector assignment was broken, and this was fixed too.