Merged
Conversation
jsongerber
pushed a commit
to jsongerber/python-sagemcom-api
that referenced
this pull request
Nov 8, 2024
This pull request includes several important changes to the GitHub Actions workflow for releases. The changes focus on configuring the environment, updating permissions, and improving the build and publish steps. ### Workflow configuration: * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R13-R17): Added the `environment: release` setting to the `deploy` job to specify the environment for the release. ### Permissions: * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R13-R17): Added `id-token: write` permission, which is mandatory for trusted publishing. ### Build and publish steps: * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L35-R44): Split the build and publish steps into two separate actions. The build step now only builds the package distribution, and the publish step uses the `pypa/gh-action-pypi-publish@release/v1` action to publish the package distributions to PyPI.
bakonyiferenc
pushed a commit
to bakonyiferenc/python-sagemcom-api
that referenced
this pull request
Dec 16, 2025
This pull request includes several important changes to the GitHub Actions workflow for releases. The changes focus on configuring the environment, updating permissions, and improving the build and publish steps. ### Workflow configuration: * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R13-R17): Added the `environment: release` setting to the `deploy` job to specify the environment for the release. ### Permissions: * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R13-R17): Added `id-token: write` permission, which is mandatory for trusted publishing. ### Build and publish steps: * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L35-R44): Split the build and publish steps into two separate actions. The build step now only builds the package distribution, and the publish step uses the `pypa/gh-action-pypi-publish@release/v1` action to publish the package distributions to PyPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several important changes to the GitHub Actions workflow for releases. The changes focus on configuring the environment, updating permissions, and improving the build and publish steps.
Workflow configuration:
.github/workflows/release.yml: Added theenvironment: releasesetting to thedeployjob to specify the environment for the release.Permissions:
.github/workflows/release.yml: Addedid-token: writepermission, which is mandatory for trusted publishing.Build and publish steps:
.github/workflows/release.yml: Split the build and publish steps into two separate actions. The build step now only builds the package distribution, and the publish step uses thepypa/gh-action-pypi-publish@release/v1action to publish the package distributions to PyPI.