Fix mem mgr not initialized#745
Merged
dblnz merged 2 commits intohyperlight-dev:mainfrom Jul 30, 2025
Merged
Conversation
06852fa to
03cda9d
Compare
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
03cda9d to
a32e8b4
Compare
simongdavies
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running with tracing enabled, hyperlight returns
mem_mgr not initializederror.This is because to call the
initialiseAPI on a Hypervisor, and avoid the borrowing conflicts, we takemem_mgrfrom an option and put it back after the call finalizes.However, when the guest exits for a IO/MMIO operation, the
handle_iomethod checks for themem_mgrbefore taking it, which will be None in this case and fail.Fix
Avoid providing a reference to mem_mgr to the
handle_mem_accessfunction, and do that through theHypervisorreference we already have in that place.Caveat: The
takeing and putting back ofmem_mgrinhandle_iostill remains becausehandle_outbfunction takes mutable references to bothmem_mgrandHypervisorat the same time