Re-export macros in hyperlight_guest_tracing#734
Merged
dblnz merged 2 commits intohyperlight-dev:mainfrom Jul 31, 2025
Merged
Conversation
Contributor
simongdavies
left a comment
There was a problem hiding this comment.
Why is macros optional? What are the circumstances where I would use tracing and not macros?
bf1069b to
365c8ac
Compare
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
365c8ac to
330dca0
Compare
simongdavies
approved these changes
Jul 30, 2025
ludfjig
approved these changes
Jul 31, 2025
jprendes
reviewed
Jul 31, 2025
Comment on lines
-107
to
-109
| if lit_str.value().is_empty() { | ||
| return Err(input.error("trace message must not be empty")); | ||
| } |
Contributor
There was a problem hiding this comment.
question: Where did the "trace message must not be empty" check move to?
Contributor
We would still need to publish both, as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to use the tracing functionality as a dependency for a guest, we need to publish the crates.
It would be best if we could only publish one crate:
hyperlight-guest-tracing.This PR re-exports the macros in the
hyperlight-guest-tracingcrate fromhyperlight-guest-tracing-macrocrate so the users don't need to have two dependencies.TODO: Need to publish the crate when releasing.