make socket component example work#624
Merged
jsturtevant merged 2 commits intohyperlight-dev:mainfrom Jun 13, 2025
Merged
Conversation
Contributor
Author
|
It's worth noting that the branch that hyperlight-wasm was using until now didn't derive those traits either: |
9cf240f to
0871eaf
Compare
Contributor
This seems reasonable to me. We may want to look at how we handle testing variants with resources in them in the future to cover our bases. This is the wit that generated this issue: |
jsturtevant
approved these changes
Jun 13, 2025
ludfjig
approved these changes
Jun 13, 2025
marosset
approved these changes
Jun 13, 2025
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
ludfjig
pushed a commit
to ludfjig/hyperlight
that referenced
this pull request
Jun 14, 2025
* make socket component example work Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> * bump Cargo.lock for witguest Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> --------- Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
ludfjig
added a commit
that referenced
this pull request
Jun 14, 2025
* Update Crate descriptions for guest crates (#590) Add verification of crate versions for new crates to Crate Publish job Amend the order of crate publishing to account for dependencies Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com> * Make cargo publish only publish unreleased crates (#623) Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * make socket component example work (#624) * make socket component example work Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> * bump Cargo.lock for witguest Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> --------- Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> --------- Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com> Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> Co-authored-by: Simon Davies <simongdavies@users.noreply.github.com> Co-authored-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
CloneandPartialEqrequirement fromvariantandrecordwit types.This change makes the
hyperlight-wasm-sockets-exampleexample work.