Prevent openat from trapping on seccomp thread, by making it return EACCES instead#573
Merged
ludfjig merged 2 commits intohyperlight-dev:mainfrom Jun 6, 2025
Merged
Prevent openat from trapping on seccomp thread, by making it return EACCES instead#573ludfjig merged 2 commits intohyperlight-dev:mainfrom
ludfjig merged 2 commits intohyperlight-dev:mainfrom
Conversation
…ACCES instead Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
jprendes
reviewed
Jun 5, 2025
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen CI being flaky due to a sporatic
openatsyscall. Turns out (g)libc can try to open/proc/sys/vm/overcommit_memoryduring a call tofree().This PRs makes
openatreturnEACCESrather than trap.An alternative solution I tried is to "prime" malloc/free before applying the seccompfilter, but that didn't work.
Closes #175