Merged
Conversation
Do best effort clean up of the files at end of run. Closes hyperlight-dev#1061 Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
ludfjig
approved these changes
Feb 20, 2026
Contributor
ludfjig
left a comment
There was a problem hiding this comment.
Do we know why this was flaky? I know it failed on deleting the files, but not sure why
Contributor
Author
Not sure, this was masking the real reason so if it occurs again we might get a better message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do best effort clean up of the files at end of run. The actuall test might be failing so this should make it so we get to that error message.
Closes #1061
Signed-off-by: James Sturtevant jsturtevant@gmail.com